Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MX-463] - Disable idfa collection in segment #3805

Merged
merged 4 commits into from
Sep 1, 2020
Merged

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Sep 1, 2020

The type of this PR is: Chore

This PR resolves MX-463

Description

This disables tracking IDFA in Segment in preparation for new iOS 14 changes around its collection:
https://developer.apple.com/app-store/user-privacy-and-data-use/

Since we use ARAnalytics pod with the default segment provider this creates a custom subclass of the default Segment analytics provider with the only change being disabling this tracking on initialization.

Note: Segment is releasing an update sometime soon that removes this tracking code entirely and replaces it with a block based approach, we may want to update to that version when the time comes: segmentio/analytics-ios#892

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests. going to manually test at the end of related changes that analytics events are still coming through as expected
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)

Copy link
Contributor

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@artsy-peril artsy-peril bot merged commit 0ae3348 into master Sep 1, 2020
@artsy-peril artsy-peril bot deleted the brian/segment-idfa branch September 1, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants